Add NVM_AUTO_REVERT option when using NVM_AUTO_USE #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucraraujo
changed the title
|
Thanks, this looks like a good change 👍 I have limited time to spend on OSS at the moment but I'll give you a hand with the tests when I can. Feel free to give it a bash on your own if you feel up to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created an option to disable the "auto revert" feature.
I find the "auto use" a little bit annoying due to auto revert. It may slow down my terminal use because every time a leave a folder with a .nvmrc file, it will revert to default nvm environment configured.
I need some help to write the tests since I'm not used to the test tool used in the project.