fix: avoid chart settings api call for anonymous user (#139)

ludeknovy · Apr 19, 2021 · f827e71 · f827e71
1 parent e1f690a
commit f827e71
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/src/app/item-detail/analyze-charts/analyze-charts.component.ts b/src/app/item-detail/analyze-charts/analyze-charts.component.ts
@@ -2,7 +2,6 @@ import { Component, Input, OnInit } from '@angular/core';
 import { customChartSettings } from 'src/app/graphs/item-detail';
 import * as Highcharts from 'highcharts';
 import { ItemsApiService } from 'src/app/items-api.service';
-import { Observable } from 'rxjs';
 
 @Component({
   selector: 'app-analyze-charts',
@@ -13,6 +12,7 @@ export class AnalyzeChartsComponent implements OnInit {
 
   @Input() params: { projectName: string, scenarioName: string, id: string };
   @Input() chartLines: ChartLines;
+  @Input() isAnonymous: boolean;
   Highcharts: typeof Highcharts = Highcharts;
   customChartsOptions = {
     ...customChartSettings(), series: []
@@ -34,12 +34,15 @@ export class AnalyzeChartsComponent implements OnInit {
   }
 
   ngOnInit() {
+    if (this.isAnonymous) {
+      return;
+    }
     this.itemApiService
-      .fetchItemChartSettings(this.params.projectName, this.params.scenarioName, this.params.id)
-      .subscribe(_ => {
-        this.updateChart(_);
-        this.preloadedSeries = _;
-      });
+    .fetchItemChartSettings(this.params.projectName, this.params.scenarioName, this.params.id)
+    .subscribe(_ => {
+      this.updateChart(_);
+      this.preloadedSeries = _;
+    });
   }
 
   chartUpdated(event: [{ name: string, metric: string }]) {
@@ -80,6 +83,9 @@ export class AnalyzeChartsComponent implements OnInit {
   }
 
   private saveChartSettings(event) {
+    if (this.isAnonymous) {
+      return;
+    }
     this.itemApiService.upsertItemChartSettings(
       this.params.projectName,
       this.params.scenarioName,

diff --git a/src/app/item-detail/item-detail.component.html b/src/app/item-detail/item-detail.component.html
@@ -277,7 +277,7 @@ <h6 class="card-header bg-transparent">Overall Chart</h6>
             <ng-template ngbNavContent>
               <div class="row chart-fix charts">
                 <div class="col">
-                  <app-analyze-charts [chartLines]="chartLines" [params]="itemParams"></app-analyze-charts>
+                  <app-analyze-charts [chartLines]="chartLines" [params]="itemParams" [isAnonymous]="isAnonymous"></app-analyze-charts>
                 </div>
               </div>