standard deviation metric (#313)

ludeknovy · Mar 17, 2023 · 2af9e39 · 2af9e39
1 parent f50352c
commit 2af9e39
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 1 deletion.
diff --git a/src/app/item-detail/request-stats/request-stats-compare.component.html b/src/app/item-detail/request-stats/request-stats-compare.component.html
@@ -64,6 +64,9 @@ <h6 class="card-header bg-transparent">Request Statistics <span class="compare">
             <th scope="col" class="hd jtl-head-color" *ngIf="displayColumn(itemData.userSettings?.requestStats?.avg)">
               <mfDefaultSorter by="avgResponseTime">avg [{{ defaultUnit ? "ms" : "%" }}]</mfDefaultSorter>
             </th>
+            <th scope="col" class="hd jtl-head-color" *ngIf="displayColumn(itemData.userSettings?.requestStats?.standardDeviation)">
+              <mfDefaultSorter by="avgResponseTime">std {{ defaultUnit ? "" : "[%]" }}</mfDefaultSorter>
+            </th>
             <th scope="col" class="hd jtl-head-color" *ngIf="displayColumn(itemData.userSettings?.requestStats?.min)">
               <mfDefaultSorter by="minResponseTime">min [{{ defaultUnit ? "ms" : "%" }}]</mfDefaultSorter>
             </th>
@@ -114,6 +117,9 @@ <h6 class="card-header bg-transparent">Request Statistics <span class="compare">
               <td *ngIf="displayColumn(itemData.userSettings?.requestStats?.avg)"><span
                 [className]="comparedData ? _.avgResponseTime > 0 ? 'value-positive' : 'value-negative' : ''">{{_.avgResponseTime | number: '1.0-2'}}</span>
               </td>
+              <td *ngIf="displayColumn(itemData.userSettings?.requestStats?.standardDeviation)"><span
+                [className]="comparedData ? _.standardDeviation > 0 ? 'value-positive' : 'value-negative' : ''">{{_.standardDeviation | number: '1.0-2'}}</span>
+              </td>
               <td *ngIf="displayColumn(itemData.userSettings?.requestStats?.min)"><span
                 [className]="comparedData ? _.minResponseTime > 0 ? 'value-positive' : 'value-negative' : ''">{{_.minResponseTime | number: '1.0-2'}}</span>
               </td>

diff --git a/src/app/item-detail/request-stats/request-stats-compare.component.spec.ts b/src/app/item-detail/request-stats/request-stats-compare.component.spec.ts
@@ -79,6 +79,7 @@ describe("RequestStatsCompareComponent", () => {
           min: true,
           p95: true,
           apdex: true,
+          standardDeviation: true,
         }
       },
       baseId: "",

diff --git a/src/app/item-detail/request-stats/request-stats-compare.component.ts b/src/app/item-detail/request-stats/request-stats-compare.component.ts
@@ -290,7 +290,7 @@ export class RequestStatsCompareComponent implements OnInit, OnDestroy {
       avg: true, min: true,
       max: true,  p90: true, p95: true,
       p99: true, throughput: true, network: true,
-      errorRate: true }
+      errorRate: true, standardDeviation: true }
     } = this.itemData.userSettings;
     const dataToBeSaved = this.labelsData.map((label) => {
       return {

diff --git a/src/app/scenario.service.model.ts b/src/app/scenario.service.model.ts
@@ -28,4 +28,5 @@ export interface RequestStats {
   samples: boolean
   throughput: boolean
   apdex: boolean
+  standardDeviation: boolean
 }
diff --git a/src/app/scenario/scenario-settings/scenario-settings.component.html b/src/app/scenario/scenario-settings/scenario-settings.component.html
@@ -314,6 +314,11 @@ <h6>Generate extra chart aggregations <i class="fas fa-flask"></i></h6>
                          formControlName="avg">
                   <label class="custom-control-label" for="rs-avg">Response Time [avg]</label>
                 </div>
+                <div class="custom-control custom-switch">
+                  <input type="checkbox" class="custom-control-input" id="rs-std"
+                         formControlName="standardDeviation">
+                  <label class="custom-control-label" for="rs-std">Standard Deviation</label>
+                </div>
                 <div class="custom-control custom-switch">
                   <input type="checkbox" class="custom-control-input" id="rs-p90"
                          formControlName="p90">

diff --git a/src/app/scenario/scenario-settings/scenario-settings.component.ts b/src/app/scenario/scenario-settings/scenario-settings.component.ts
@@ -64,6 +64,7 @@ export class SettingsScenarioComponent implements OnInit {
     network: null,
     errorRate: null,
     apdex: null,
+    standardDeviation: null
   };
   apdexFormControls = {
     apdexEnabled: null,
@@ -204,6 +205,7 @@ export class SettingsScenarioComponent implements OnInit {
 
     this.requestStatsCormControls.samples = new FormControl(settings.userSettings.requestStats.samples, [Validators.required]);
     this.requestStatsCormControls.avg = new FormControl(settings.userSettings.requestStats.avg, [Validators.required]);
+    this.requestStatsCormControls.standardDeviation = new FormControl(settings.userSettings.requestStats.standardDeviation || true, [Validators.required]);
     this.requestStatsCormControls.min = new FormControl(settings.userSettings.requestStats.min, [Validators.required]);
     this.requestStatsCormControls.max = new FormControl(settings.userSettings.requestStats.max, [Validators.required]);
     this.requestStatsCormControls.p90 = new FormControl(settings.userSettings.requestStats.p90, [Validators.required]);
@@ -262,6 +264,7 @@ export class SettingsScenarioComponent implements OnInit {
       network: this.requestStatsCormControls.network,
       errorRate: this.requestStatsCormControls.errorRate,
       apdex: this.requestStatsCormControls.apdex,
+      standardDeviation: this.requestStatsCormControls.standardDeviation,
     });
     this.labelFiltersForm = new FormGroup({});
     this.apdexSettingsForm = new FormGroup({