request stats failure (#331)

ludeknovy · Jun 5, 2023 · 0da5057 · 0da5057
1 parent b3da63a
commit 0da5057
Show file tree

Hide file tree

Showing 7 changed files with 38 additions and 1 deletion.
diff --git a/src/app/item-detail/item-detail.component.html b/src/app/item-detail/item-detail.component.html
@@ -401,6 +401,9 @@ <h6 class="card-header bg-transparent">Target System Statistics <span class="com
                     <th scope="col" class="hd jtl-head-color">
                       <mfDefaultSorter by="errorRate">error rate [%]</mfDefaultSorter>
                     </th>
+                    <th scope="col" class="hd jtl-head-color">
+                      <mfDefaultSorter by="errorRate">error rate [%]</mfDefaultSorter>
+                    </th>
                     <th scope="col" class="hd jtl-head-color">
                     </th>
                     <th scope="col" class="hd jtl-head-color">

diff --git a/src/app/item-detail/request-stats/request-stats-compare.component.html b/src/app/item-detail/request-stats/request-stats-compare.component.html
@@ -95,6 +95,10 @@ <h6 class="card-header bg-transparent">Request Statistics <span class="compare">
               *ngIf="displayColumn(itemData.userSettings?.requestStats?.errorRate)">
             <mfDefaultSorter by="errorRate">error rate [%]</mfDefaultSorter>
           </th>
+          <th scope="col" class="hd jtl-head-color"
+              *ngIf="displayColumn(itemData.userSettings?.requestStats?.failures, false)">
+            <mfDefaultSorter by="failures">failures</mfDefaultSorter>
+          </th>
           <th scope="col" class="hd jtl-head-color"
               *ngIf="displayColumn(itemData.userSettings?.requestStats?.apdex, false)">
             <mfDefaultSorter [by]="sortByApdex">apdex</mfDefaultSorter>
@@ -159,6 +163,10 @@ <h6 class="card-header bg-transparent">Request Statistics <span class="compare">
               <span
                 [className]="comparedData ? _.errorRate > 0 ? 'value-positive' : 'value-negative' : ''">{{_.errorRate | number: '1.0-2'}}</span>
             </td>
+            <td *ngIf="displayColumn(itemData.userSettings?.requestStats?.failures, false)">
+              <span
+                [className]="comparedData ? _.failures > 0 ? 'value-positive' : 'value-negative' : ''">{{_.failures | number: '1.0-2'}}</span>
+            </td>
             <td *ngIf="displayColumn(itemData.userSettings?.requestStats?.apdex, false)">
               <span>
                  {{ calculateApdex(_.apdex?.satisfaction, _.apdex?.toleration, _.samples)}}

diff --git a/src/app/item-detail/request-stats/request-stats-compare.component.spec.ts b/src/app/item-detail/request-stats/request-stats-compare.component.spec.ts
@@ -79,6 +79,7 @@ describe("RequestStatsCompareComponent", () => {
           p95: true,
           apdex: true,
           standardDeviation: true,
+          failures: true,
         }
       },
       baseId: "",

diff --git a/src/app/item-detail/request-stats/request-stats-compare.component.ts b/src/app/item-detail/request-stats/request-stats-compare.component.ts
@@ -48,6 +48,18 @@ export class RequestStatsCompareComponent implements OnInit, OnDestroy {
   }
 
   ngOnInit() {
+    // enrich the data with failure count
+    this.itemData.statistics.map(labelData => {
+      const failureCount = labelData.responseMessageFailures.reduce(
+        (previousValue, currentValue) => {
+          previousValue.count += currentValue.count
+          return previousValue
+        },{ count: 0 })
+
+      Object.assign(labelData, { failures: failureCount.count })
+      return labelData
+    })
+
     if (this.itemData?.thresholds?.passed === false) {
       this.labelsData = this.itemData.statistics.map(labelData => {
         const thresholdResult = this.itemData.thresholds.results.find(thresholdResult =>
@@ -65,6 +77,7 @@ export class RequestStatsCompareComponent implements OnInit, OnDestroy {
     } else {
       this.labelsData = this.itemData.statistics;
     }
+    console.log(this.labelsData)
     this.analyzeChartService.currentData.subscribe(data => {
       if (data && data.label) {
         this.search(data.label);

diff --git a/src/app/scenario.service.model.ts b/src/app/scenario.service.model.ts
@@ -30,4 +30,5 @@ export interface RequestStats {
   throughput: boolean
   apdex: boolean
   standardDeviation: boolean
+  failures: boolean
 }
diff --git a/src/app/scenario/scenario-settings/scenario-settings.component.html b/src/app/scenario/scenario-settings/scenario-settings.component.html
@@ -364,6 +364,11 @@ <h6>Generate extra chart aggregations <i class="fas fa-flask"></i></h6>
                          formControlName="errorRate">
                   <label class="custom-control-label" for="rs-error-rate">Error Rate</label>
                 </div>
+                <div class="custom-control custom-switch">
+                  <input type="checkbox" class="custom-control-input" id="rs-failures"
+                         formControlName="failures">
+                  <label class="custom-control-label" for="rs-failures">Failures</label>
+                </div>
                 <div class="custom-control custom-switch">
                   <input type="checkbox" class="custom-control-input" id="rs-apdex"
                          formControlName="apdex">

diff --git a/src/app/scenario/scenario-settings/scenario-settings.component.ts b/src/app/scenario/scenario-settings/scenario-settings.component.ts
@@ -50,6 +50,7 @@ export class SettingsScenarioComponent implements OnInit {
     avgConnectionTime: null,
     avgLatency: null,
     errorRate: null,
+    failures: null,
   };
   labelFilterControls = {};
   requestStatsCormControls = {
@@ -64,7 +65,8 @@ export class SettingsScenarioComponent implements OnInit {
     network: null,
     errorRate: null,
     apdex: null,
-    standardDeviation: null
+    standardDeviation: null,
+    failures: null
   };
   apdexFormControls = {
     apdexEnabled: null,
@@ -206,6 +208,8 @@ export class SettingsScenarioComponent implements OnInit {
     this.labelTrendChartControls.p95 = new FormControl(settings.labelTrendChartSettings?.p95, []);
     this.labelTrendChartControls.p99 = new FormControl(settings.labelTrendChartSettings?.p99, []);
     this.labelTrendChartControls.errorRate = new FormControl(settings.labelTrendChartSettings?.errorRate, []);
+    this.labelTrendChartControls.failures = new FormControl(settings.labelTrendChartSettings?.failures, []);
+
 
     this.requestStatsCormControls.samples = new FormControl(settings.userSettings.requestStats.samples, [Validators.required]);
     this.requestStatsCormControls.avg = new FormControl(settings.userSettings.requestStats.avg, [Validators.required]);
@@ -218,6 +222,7 @@ export class SettingsScenarioComponent implements OnInit {
     this.requestStatsCormControls.throughput = new FormControl(settings.userSettings.requestStats.throughput, [Validators.required]);
     this.requestStatsCormControls.network = new FormControl(settings.userSettings.requestStats.network, [Validators.required]);
     this.requestStatsCormControls.errorRate = new FormControl(settings.userSettings.requestStats.errorRate, [Validators.required]);
+    this.requestStatsCormControls.failures = new FormControl(settings.userSettings.requestStats.failures, [Validators.required]);
     this.requestStatsCormControls.apdex = new FormControl(settings.userSettings.requestStats.apdex || false, [Validators.required]);
 
     this.apdexFormControls.satisfyingThreshold = new FormControl(settings?.apdexSettings?.satisfyingThreshold, [
@@ -267,6 +272,7 @@ export class SettingsScenarioComponent implements OnInit {
       throughput: this.requestStatsCormControls.throughput,
       network: this.requestStatsCormControls.network,
       errorRate: this.requestStatsCormControls.errorRate,
+      failures: this.requestStatsCormControls.failures,
       apdex: this.requestStatsCormControls.apdex,
       standardDeviation: this.requestStatsCormControls.standardDeviation,
     });