xlsx version upgraded (#283)

ludeknovy · Jan 22, 2024 · b1dcbb0 · b1dcbb0
1 parent b050d77
commit b1dcbb0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 92 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -42,7 +42,7 @@
     "swagger-ui-express": "^4.6.3",
     "uuid": "^9.0.1",
     "winston": "^3.10.0",
-    "xlsx": "^0.18.5"
+    "xlsx": "https://cdn.sheetjs.com/xlsx-0.20.1/xlsx-0.20.1.tgz"
   },
   "devDependencies": {
     "@types/boom": "^7.2.0",

diff --git a/src/server/routes/item.ts b/src/server/routes/item.ts
@@ -88,6 +88,7 @@ export class ItemsRoutes {
                 projectExistsMiddleware,
                 wrapAsync((req: Request, res: Response) => deleteItemController(req, res)))
 
+        // https://github.com/ludeknovy/jtl-reporter/issues/159
         app.route("/api/projects/:projectName/scenarios/:scenarioName/items/:itemId/request-stats-export")
             .get(
                 authenticationMiddleware,

diff --git a/src/server/utils/excel-service.ts b/src/server/utils/excel-service.ts
@@ -4,9 +4,8 @@ export class ExcelService {
 
 
   static generateExcelBuffer(json: unknown[]): string {
-    const myworksheet: XLSX.WorkSheet = XLSX.utils.json_to_sheet(json)
-    const myworkbook: XLSX.WorkBook = { Sheets: { data: myworksheet }, SheetNames: ["data"] }
-    return XLSX.write(myworkbook, { bookType: "xlsx", bookSST: false, type: "base64" })
+    const worksheet: XLSX.WorkSheet = XLSX.utils.json_to_sheet(json)
+    const workbook: XLSX.WorkBook = { Sheets: { data: worksheet }, SheetNames: ["data"] }
+    return XLSX.write(workbook, { bookType: "xlsx", bookSST: false, type: "base64" })
   }
-
 }