Patch stateless tokens tutorial #1808
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the keyUsage arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You guys have created an amazing auth tutorial! I have learned a lot from implementing this myself.
I noticed a few small things missing or things that I needed to figure out myself in the 'stateless-tokens' tutorial because they were not clear straight away. I have added these in the PR.
Things added:
keyUsagesargument incrypto.subtle.importKeycalls. Based on this documentation: https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/importKey.oslo_jwt.encodeJWTcall. Also, I added some pointers on how to safely create, store and obtain the signing key.I am curious what you guys think about the additions :).
Kind regards,
Tom