Add SameSite=None option (#1546)

lucia-auth · Apr 24, 2024 · 20793d6 · 20793d6
1 parent a84e63e
commit 20793d6
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 9 deletions.
diff --git a/.auri/$e3mj84c4.md → .auri/$49d0lzfc.md b/.auri/$e3mj84c4.md → .auri/$49d0lzfc.md
@@ -3,4 +3,4 @@ package: "lucia" # package name
 type: "patch" # "major", "minor", "patch"
 ---
 
-Fix `LegacyScrypt` generating malformed hash (see PR for fix)
+Fix `options.sessionCookie` parameter type in `Lucia`
diff --git a/docs/pages/reference/main/Lucia/index.md b/docs/pages/reference/main/Lucia/index.md
@@ -22,7 +22,7 @@ function constructor<
 			name?: string;
 			expires?: boolean;
 			attributes: {
-				sameSite?: "lax" | "strict";
+				sameSite?: "lax" | "strict" | "none";
 				domain?: string;
 				path?: string;
 				secure?: boolean;

diff --git a/docs/pages/tutorials/github-oauth/sveltekit.md b/docs/pages/tutorials/github-oauth/sveltekit.md
@@ -80,12 +80,9 @@ Initialize the GitHub provider with the client ID and secret.
 // src/lib/server/auth.ts
 // ...
 import { GitHub } from "arctic";
-import { GITHUB_CLIENT_ID, GITHUB_CLIENT_SECRET } from '$env/static/private';
+import { GITHUB_CLIENT_ID, GITHUB_CLIENT_SECRET } from "$env/static/private";
 
-export const github = new GitHub(
-	GITHUB_CLIENT_ID,
-	GITHUB_CLIENT_SECRET
-);
+export const github = new GitHub(GITHUB_CLIENT_ID, GITHUB_CLIENT_SECRET);
 ```
 
 ## Sign in page

diff --git a/packages/adapter-postgresql/CHANGELOG.md b/packages/adapter-postgresql/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## 3.1.2
 
-- Update peer dependencies.
+-   Update peer dependencies.
 
 ## 3.1.1
 

diff --git a/packages/lucia/src/core.ts b/packages/lucia/src/core.ts
@@ -220,7 +220,7 @@ export interface SessionCookieOptions {
 }
 
 export interface SessionCookieAttributesOptions {
-	sameSite?: "lax" | "strict";
+	sameSite?: "lax" | "strict" | "none";
 	domain?: string;
 	path?: string;
 	secure?: boolean;