Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Move client course and layouts module to core and assessment-dasboard to assessment #10532

Merged
merged 13 commits into from
Mar 23, 2025
Merged

Development: Move client course and layouts module to core and assessment-dasboard to assessment #10532

merged 13 commits into from
Mar 23, 2025

Conversation

tobias-lippert
Copy link
Contributor

@tobias-lippert tobias-lippert commented Mar 19, 2025 •
edited
Loading

Checklist

General

Client

Motivation and Context

#10492 had still some issues that were postponed to a follow-up to get it quickly merged.

  1. Remove Orion, -> Development: Remove orion plugin integration #10517
  2. Move course module to core to follow the structure on the server side -> this PR
  3. Move top-level components to shared -> Development: Move entities and non-shared components to the corresponding modules in the client #10552
  4. Move components from shared to their respective module -> Development: Move entities and non-shared components to the corresponding modules in the client #10552
  5. Move entities to respective modules -> one, or more follow up PRs.

Description

Moved course into core.
Moved assessment-dashboard from course to assessment
Moved layouts from shared to core.

Steps for Testing

Code Review

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

  • Code Review 1

Test Coverage

I only moved files.

Summary by CodeRabbit

Summary by CodeRabbit

  • Refactor
    • Internal module and import path reorganization was performed across many parts of the application.
    • Consolidated shared utilities and services to improve code maintainability without affecting functionality or user experience.

@tobias-lippert
move course to core
08b8533
@tobias-lippert
Merge branch 'refs/heads/develop' into chore/client-module-structure-…
4bb2890 
…improvement

# Conflicts:
#	src/main/webapp/app/communication/posting-markdown-editor/posting-markdown-editor.component.ts
#	src/main/webapp/app/core/course/overview/course-overview.component.ts
#	src/test/javascript/spec/component/course/course-overview.component.spec.ts
@tobias-lippert
Merge branch 'develop' into chore/client-module-structure-improvement
8bc3ea8 
# Conflicts:
#	src/main/webapp/app/fileupload/manage/file-upload-exercise-management-resolve.service.ts
@tobias-lippert
move more files from top level
fec7c15
@github-actions github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) assessment Pull requests that affect the corresponding module atlas Pull requests that affect the corresponding module communication Pull requests that affect the corresponding module core Pull requests that affect the corresponding module exam Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module fileupload Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module lti Pull requests that affect the corresponding module modeling Pull requests that affect the corresponding module plagiarism Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module quiz Pull requests that affect the corresponding module text Pull requests that affect the corresponding module tutorialgroup Pull requests that affect the corresponding module labels Mar 19, 2025
@github-actions github-actions bot added the buildagent Pull requests that affect the corresponding module label Mar 20, 2025
@tobias-lippert tobias-lippert removed assessment Pull requests that affect the corresponding module atlas Pull requests that affect the corresponding module buildagent Pull requests that affect the corresponding module communication Pull requests that affect the corresponding module core Pull requests that affect the corresponding module labels Mar 20, 2025
@tobias-lippert tobias-lippert force-pushed the chore/client-module-structure-improvement branch from 6c9340b to eacb16a Compare March 21, 2025 22:14
@github-actions github-actions bot removed the buildagent Pull requests that affect the corresponding module label Mar 21, 2025
@tobias-lippert tobias-lippert changed the title Development: Improve shared client module structure Development: Move client course module to core and top level directories to shared Mar 21, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Mar 21, 2025
View reviewed changes
coderabbitai[bot]
coderabbitai bot previously approved these changes Mar 22, 2025
View reviewed changes
@tobias-lippert tobias-lippert changed the title Development: Move client course module to core and top level directories to shared Development: Move client course module to core Mar 22, 2025
@tobias-lippert tobias-lippert changed the title Development: Move client course module to core Development: Move client course and layouts module to core and assessment-dasboard to assessment Mar 22, 2025
coolchock
coolchock approved these changes Mar 23, 2025
View reviewed changes
Copy link
Contributor

@coolchock coolchock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me 👍

@krusche krusche added this to the 8.0 milestone Mar 23, 2025
@krusche krusche merged commit a18c25d into develop Mar 23, 2025
28 of 31 checks passed
@krusche krusche deleted the chore/client-module-structure-improvement branch March 23, 2025 17:32
This was referenced Mar 24, 2025
Closed
Closed
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krusche krusche krusche approved these changes

@coolchock coolchock coolchock approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@florian-glombik florian-glombik Awaiting requested review from florian-glombik

Assignees

@tobias-lippert tobias-lippert

Labels
assessment Pull requests that affect the corresponding module atlas Pull requests that affect the corresponding module client Pull requests that update TypeScript code. (Added Automatically!) communication Pull requests that affect the corresponding module core Pull requests that affect the corresponding module exam Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module fileupload Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module lti Pull requests that affect the corresponding module modeling Pull requests that affect the corresponding module plagiarism Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module quiz Pull requests that affect the corresponding module ready to merge tests text Pull requests that affect the corresponding module tutorialgroup Pull requests that affect the corresponding module
Projects
Artemis Development
Status: Merged
Communication Webclient
Status: Done
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tobias-lippert @krusche @florian-glombik @coolchock