Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more sample name options #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

troycomi
Copy link
Collaborator

  • Added an argument to get_samplename_list so samples can be matched
    with population, superpopulation or sample.
  • Added options to specify modern super population and archaic sample
  • Changed logic of parser so none of those are required. Instead,
    check if either list is empty and raise an exception if so indicating
    which options should be specified.

- Added an argument to get_samplename_list so samples can be matched
  with population, superpopulation or sample.
- Added options to specify modern super population and archaic sample
- Changed logic of parser so none of those are required.  Instead,
  check if either list is empty and raise an exception if so indicating
  which options should be specified.
Copy link
Owner

@lparsons lparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition, it looks good to me!

Before we merge, could we add a note to the changelog and bump the version number?

@troycomi
Copy link
Collaborator Author

Will add in the next push. It will be a few days before the empirical data is run through.

- Added option to match superpopulation of query to population of the
  null database.  Necessary for current simulation framework.
- Bumped version number
- Updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants