Remove MemoryFS dependency on Windows Path implementation #1241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, long term fan of language-ext 馃槃
I ran all
LanguageExt.Tests
tests on macOS (.NET 7.0) and some fail, mostly due toMemoryFS
usingPath.IsPathRooted()
,Path.DirectorySeparatorChar
etc with error:In this PR I've modified
MemoryFS
andMemoryFSTests
to behave the same independent of the host OS, and therefore enable the tests to pass. The replacement methods aren't 100% realistic but I hope acceptable for this usage. There remains a dependency onSystem.IO
for some exceptions and other types.MemoryFS
use of Windows file paths is unchanged so there is no breaking change.Thanks