(Issue #119) Added pause functionality to builtins #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordmauve
requested changes
Sep 19, 2018
examples/asteroids/main.py
Outdated
| @@ -3,6 +3,7 @@ | |||
| import operator | |||
|
|
|||
| from pygame.math import Vector2 | |||
| from pgzero.builtins import pause, is_paused | |||
There was a problem hiding this comment.
You don't need to import the builtins - anything in builtins is already available.
|
|
||
| if update: | ||
| if update and not paused: | ||
| pgzclock.tick(dt) |
There was a problem hiding this comment.
This is wrong - pgzclock needs to run if not paused, even if update is not defined.
pgzero/game.py
Outdated
| @@ -243,7 +250,7 @@ def mainloop(self): | |||
|
|
|||
| pgzclock = pgzero.clock.clock | |||
|
|
|||
| self.need_redraw = True | |||
| self.need_redraw = not paused | |||
There was a problem hiding this comment.
I don't think this is right - this is at the start of the game while the pause state will change during the game loop.
Moving the logic for need_redraw to more relevant places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the following issue: #119