🐄 Convert Backend's &str to Cow instead #114
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44
This is a breaking change to the
Backend
trait, but it stems from the realization that thei18n
macro expansion always would callCow::from
on the result of bothavailable_locales
as well astranslate
.This PR just moves that responsibility over to the
Backend
trait directly, this unlocks exactly the "reloadable" backend that the original issue was talking about.Before
After