tiles: Add Tiles #435
Open
tiles: Add Tiles #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xda2023
changed the title
huacnlee
reviewed
Dec 10, 2024
crates/ui/src/dock/state.rs
Outdated
| pub(crate) x: Pixels, | ||
| pub(crate) y: Pixels, | ||
| pub(crate) w: Pixels, | ||
| pub(crate) h: Pixels, |
There was a problem hiding this comment.
GPUI's Bounds, Point how is serializable
huacnlee
reviewed
Dec 10, 2024
crates/ui/src/dock/state.rs
Outdated
| @@ -65,6 +68,16 @@ pub struct DockItemState { | |||
| pub info: DockItemInfo, | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone, Serialize, Deserialize, PartialEq)] | |||
| pub struct TilePanelState { | |||
| pub(crate) panel_state: DockItemState, | |||
huacnlee
reviewed
Dec 10, 2024
crates/ui/src/dock/tiles_panel.rs
Outdated
| initial_panel_bounds: panel_bounds, | ||
| }; | ||
| this.update_resizing_drag(drag_data, cx); | ||
| this.bring_panel_to_front(this.resizing_panel_index); |
There was a problem hiding this comment.
resizing_panel_index -> resizing_index
In the tiles, the primary item is the panel not have any other things.
So active_index, resizing_index that must means the panel.
huacnlee
reviewed
Dec 10, 2024
crates/ui/src/dock/tiles_panel.rs
Outdated
| } | ||
| let current_mouse_position = | ||
| e.event.position; | ||
| let delta = current_mouse_position.x |
There was a problem hiding this comment.
current_mouse_position -> pos or position to less code
huacnlee
reviewed
Dec 10, 2024
crates/ui/src/dock/tiles_panel.rs
Outdated
| }) | ||
| .child(if !is_occluded(&bottom_handle_bounds) { | ||
| div() | ||
| .id("bottom-resize-handle") |
There was a problem hiding this comment.
Split all resize-handle into render_resize_handles method.
huacnlee
reviewed
Dec 10, 2024
crates/ui/src/dock/tiles_panel.rs
Outdated
| }) | ||
| .child(if !is_occluded(&drag_bar_bounds) { | ||
| h_flex() | ||
| .id("drag-bar") |
There was a problem hiding this comment.
Split drag-bar to render_drag_bar method.
huacnlee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.