Feature: Added "enabled" as a feature to FastAPILimiter #12
+105
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enabled: Default value is True which changes no features, but can be set to False. When False, no limiting checks will be done.
|
I tested the results on my local machine, and added some test cases to ensure all '200' results when running the same original tests, but with enabled set to False. Sorry in advance for any mistakes, this is my first time submitting a pull request in a public repository |
|
Hey there! |
|
Thanks! Please resolve conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabled:
Default value is True which changes no features, but can be set to False.
When False, no limiting checks will be done.
Use Cases:
For debugging other features of API, excluding the Rate Limiter
For enabling/disabling Rate Limiter using an environment variable, for deployment purposes