Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade babel to 7.23.5 #1080

Merged
merged 2 commits into from
May 31, 2024

Conversation

tringenbach
Copy link
Contributor

@tringenbach tringenbach commented Jan 24, 2024

I need support for the import { type MyType } from 'package'; Typescript feature. That was added to babel in 2.16.0.

I noticed dependabot already opened an PR to upgrade but the build failed. I started with that branch, redid the upgrade to use 7.23.5, and added the webpack config change needed to make it build.

This should obsolete #1033

dependabot bot and others added 2 commits October 17, 2023 06:29
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.15.0 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@tringenbach
Copy link
Contributor Author

@terales @kibertoad Any chance you could review my PR? Or at least approve the workflow so that we can make sure the build is successful in your CI environment. (It is successful locally.)

@kibertoad kibertoad closed this May 31, 2024
@kibertoad kibertoad reopened this May 31, 2024
@kibertoad kibertoad merged commit a4004a5 into lokalise:main May 31, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants