Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table column width calculation with latex markup #11225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AyushAgrawal-A2
Copy link

@AyushAgrawal-A2 AyushAgrawal-A2 commented Apr 11, 2024

closes #10913

Changes:

  • innerText for table cell having latex markup return the actual markup, instead of the rendered character. e.g. for omega symbol "\Omega" is returned instead of "Ω". This results in incorrect width calculation. I have added a regex replace function call to replace markup text with a single character.

Before:
image

After:
image

Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andelf andelf requested a review from xyhp915 May 8, 2024 08:57
@xyhp915
Copy link
Collaborator

xyhp915 commented May 16, 2024

Hi @AyushAgrawal-A2 Thank you for your contribution. The feature of this V2 table may be removed in the future and replaced by a new table component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table column width doesn't consider Latex math
3 participants