Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto-complete for $$ and ^^ #11220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: auto-complete for $$ and ^^ #11220

wants to merge 1 commit into from
+23 −22

Conversation

AyushAgrawal-A2
Copy link

@AyushAgrawal-A2 AyushAgrawal-A2 commented Apr 10, 2024 •
edited

closes #10932

Changes:

  • Fixes auto complete for ^^
  • Fixes end cursor travel for $$

@andelf
Copy link
Collaborator

andelf commented Apr 23, 2024

This is far more difficult to implement correctly:

  • The normal case: typing two ^
  • Select some text and type two ^ - this fails

@andelf andelf self-requested a review April 23, 2024 03:44
@andelf
Copy link
Collaborator

andelf commented Apr 23, 2024

Hold this when feat/db branch is merged.

@andelf andelf added the :type/hold Hold this PR. won't merge for now label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf Awaiting requested review from andelf

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
:type/hold Hold this PR. won't merge for now
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LaTeX in-line $$ get's treated as en entry as opposed to overwriting auto-added $$ for close
2 participants
@AyushAgrawal-A2 @andelf