Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prepend the current repo name to the title if the repo exists #10953

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

farcaller
Copy link
Contributor

This adds visual distinction to windows when several graphs are open at once.

On windows specifically it's sometimes hard to discern which graph you're looking at, especially if both are on the journal page. Given there's no per-graph theme setting, there is no visual distinction in that either.

I suppose this might break some tests, but yarn test seemed fine.

@CLAassistant
Copy link

CLAassistant commented Feb 2, 2024

CLA assistant check
All committers have signed the CLA.

@farcaller farcaller changed the title Feature request: Prepend the current repo name to the title if the repo exists. feat: Prepend the current repo name to the title if the repo exists Feb 2, 2024
@andelf andelf self-requested a review February 28, 2024 05:16
This adds visual distinction to windows when several graphs are open at once.
@andelf andelf requested a review from xyhp915 February 28, 2024 08:08
@andelf
Copy link
Collaborator

andelf commented Feb 29, 2024

I've added more changes.
The title should be carefully designed.

And I noticed that some of the routes don't have entrances. Like: :settings, :new-page. PTAL @xyhp915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants