Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HWORKS-830] Configurable jvm tmp dir #1072

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[HWORKS-830] Configurable jvm tmp dir #1072

wants to merge 3 commits into from

Conversation

kouzant
Copy link
Contributor

@kouzant kouzant commented Nov 3, 2023

@kouzant kouzant requested a review from ErmiasG November 3, 2023 18:16
ErmiasG
ErmiasG requested changes Nov 6, 2023
View reviewed changes
providers/configure_server.rb
password_file password_file
target target_config
secure false
options ["-Djava.io.tmpdir=#{node['install']['tmp_directory']}/glassfish"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to create the dir?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tmp_directory is provided and Payara will create the glassfish sub-directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErmiasG ErmiasG ErmiasG requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kouzant @ErmiasG