add resource providers for vpc endpoint and prefix list #10735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzon
added
the
semver: minor
pinzon
requested review from
viren-nadkarni,
macnev2013,
dominikschubert,
simonrw and
Morijarti
as code owners
simonrw
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Provider looks good for now. I mentioned we should probably use the async form of the provider methods always since it upholds the CFn resource provider contract of atomicity. Not a blocker, we might want to do a pass over "non-conforming" providers in the future once we have more accurate deployment order
tests/aws/services/cloudformation/resource_providers/ec2/test_ec2.snapshot.json
Outdated
Show resolved
Hide resolved
localstack/services/ec2/resource_providers/aws_ec2_vpcendpoint.py
Outdated
Show resolved
Hide resolved
localstack/services/ec2/resource_providers/aws_ec2_prefixlist.py
Outdated
Show resolved
Hide resolved
localstack/services/ec2/resource_providers/aws_ec2_prefixlist.py
Outdated
Show resolved
Hide resolved
localstack/services/ec2/resource_providers/aws_ec2_prefixlist.py
Outdated
Show resolved
Hide resolved
|
@simonrw thank you for the comments. I addressed them all and made the improvements to the resource providers. I'll merge once the checks are green again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses #10606. This PR adds new resource providers for the EC2 service
Changes
Testing