Fix SubtypesInstanceManager not loading subtypes lazily #10728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
added
the
semver: patch
whummer
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
SubtypesInstanceManageris supposed to lazily create a singleton instance of subtypes and return it. However a bug caused all subtypes to be instantiated eagerly if any subtype was requested.This was identified when the Libvirt EC2 VM manager was being instantiated in the CI (which would fail since CI runners do not have a Libvirt socket) despite not being enabled explicitly in code or configuration.
Changes
Fix
SubtypesInstanceManagerso that only the requested subtype is instantiated.