Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Use EmulatorBaseStore #10680

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

bblommers
Copy link
Contributor

@bblommers bblommers commented Apr 17, 2024

Motivation

As part of the push towards LS becoming a multi-emulator platform, one of the key features is to have a generic data + persistence layer that can be used across all emulators.
This PR is a first step in that process, using a generic data store in LocalStack (AWS).

Changes

  • Introduces the EmulatorBaseStore dependency
  • Overrides the BaseStore to keep the AWS-specific validation that was already in place

Testing

Running the regular test suite is enough, as there are no changes in functionality.

TODO

What's left to do:

  • Review the EmulatorBaseStore project (private for now)
  • Decide on the naming
  • Release the EmulatorBaseStore
  • Change the dependency here to use the actual release

@bblommers bblommers added this to the Playground milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant