Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing href inside README.md #10671

Merged
merged 1 commit into from May 8, 2024

Conversation

gabriel-vasile
Copy link
Contributor

Previously: install, installation, and installing we're all used. Clicking on Install link inside README did nothing.
Currently: use install everywhere.

Changes

  • fix a link that is not working in README

Previously: `install`, `installation`, and `installing` we're all used.
Currently: use `install` everywhere.
Copy link
Collaborator

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Collaborator

localstack-bot commented Apr 16, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@gabriel-vasile
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Apr 16, 2024
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for proactively fixing the link with this PR! 💯
Sorry for the delay, I'll merge this right away 😉

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label May 8, 2024
@alexrashed alexrashed merged commit 84f4a31 into localstack:master May 8, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants