fix clouformation ec2 tests for ap-northeast-1 and validate against AWS

[sannya-singal]

Motivation

Test test_vpc_creates_default_sg and test_transit_gateway_attachmentfail when run in the workflow for region: ap-northeast-1 and throws a StackDeployError.

Changes

This PR validates test: test_vpc_creates_default_sg against AWS and deploys both the tests specifically in us-east-1.

[github-actions]

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 29m 31s ⏱️ +3s
2 740 tests ±0  2 484 ✅ ±0  256 💤 ±0  0 ❌ ±0 
2 742 runs  ±0  2 484 ✅ ±0  258 💤 ±0  0 ❌ ±0 

Results for commit 67e5248. ± Comparison against base commit 3b8099b.

[sannya-singal]

we need to update the region values in: moto.ec2.models.availability_zones_and_regions.RegionsAndZonesBackend.

[Morijarti]

LGTM as not to block pipeline.
However after adding missing subnet to moto, we should revert these changes

"ap-northeast-1": [
            Zone(
                region_name="ap-northeast-1",
                name="ap-northeast-1a",
                zone_id="apne1-az4",
            ),
            Zone(
                region_name="ap-northeast-1",
                name="ap-northeast-1c",
                zone_id="apne1-az1",
            ),
            Zone(
                region_name="ap-northeast-1",
                name="ap-northeast-1d",
                zone_id="apne1-az2",
            ),
        ],

in moto/ec2/models/availability_zones_and_regions.py:143

it's a bit weird that we have 1a, 1c and 1d, but not 1b on the list

[sannya-singal]

when we check the availability zones for ap-northeast-1 on aws, we get the following:

{
    "AvailabilityZones": [
        {
            "State": "available",
            "OptInStatus": "opt-in-not-required",
            "Messages": [],
            "RegionName": "ap-northeast-1",
            "ZoneName": "ap-northeast-1a",
            "ZoneId": "apne1-az4",
            "GroupName": "ap-northeast-1",
            "NetworkBorderGroup": "ap-northeast-1",
            "ZoneType": "availability-zone"
        },
        {
            "State": "available",
            "OptInStatus": "opt-in-not-required",
            "Messages": [],
            "RegionName": "ap-northeast-1",
            "ZoneName": "ap-northeast-1c",
            "ZoneId": "apne1-az1",
            "GroupName": "ap-northeast-1",
            "NetworkBorderGroup": "ap-northeast-1",
            "ZoneType": "availability-zone"
        },
        {
            "State": "available",
            "OptInStatus": "opt-in-not-required",
            "Messages": [],
            "RegionName": "ap-northeast-1",
            "ZoneName": "ap-northeast-1d",
            "ZoneId": "apne1-az2",
            "GroupName": "ap-northeast-1",
            "NetworkBorderGroup": "ap-northeast-1",
            "ZoneType": "availability-zone"
        }
    ]
}

@Morijarti

[sannya-singal]

another fix for this could be selecting 1c instead here, what do you think @Morijarti

[Morijarti]

It would fix it in this case, but I think then that the real issue is in how Fn::GetAZs works. Let me give it a look @sannya-singal

[pinzon]

I'm with @Morijarti probably it would be best if you just extend the functionality of Fn::GetAZs instead of limiting the test just to force us-east-1 in the test.

[sannya-singal]

I'm with @Morijarti probably it would be best if you just extend the functionality of Fn::GetAZs instead of limiting the test just to force us-east-1 in the test.

Hey @pinzon! Thanks for the review. I and @Morijarti had a discussion today regarding the root cause of the issue, which is not clear. For now this has been marked approved to unblock #10546 and created a backlog item for this.