Fix filter for provider detection in legacy StepFunctions tests #10454
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
added
the
semver: patch
|
@MEPalma It looks like the filter now works correctly, but the tests are failing. Could you take a look at this? |
MEPalma
force-pushed
the
fix-legacy-sfn-filter
branch
from
c75bb6c
to
096cd14
Compare
dominikschubert
force-pushed
the
fix-legacy-sfn-filter
branch
from
9032d0e
to
13f2f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Noticed during my work on test selection, that the stepfunctions tests are executed particularly quickly. Looking at it in more detail I noticed that all tests are being skipped due to an issue in the conditional for the
skipifmarker.Changes