Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add util script for building/pushing Docker images #10276

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

whummer
Copy link
Member

@whummer whummer commented Feb 19, 2024

Motivation

A common use case we're seeing is to build multi-arch Docker images with semantic versioning (build tags like :3, 3.1, latest, etc), for which we currently have targets in the Makefile (docker-build, docker-push-master, docker-create-push-manifests, etc). Maintaining this non-trivial logic in the Makefile is cumbersome, and we could also benefit from making it reusable across different repos. This PR is a first step towards making these targets reusable across different repos, including -ext, the upcoming Snowflake image, etc.

Changes

Add util script for building/pushing Docker images. The script follows a similar structure as the existing bin/release-helper.sh script we already have in place.

🚧 more details following soon.. /cc @alexrashed

TODOs:

  • add logic to extract correct major/minor/patch version numbers from __version__ in __init__.py files

Testing

The script has been tested in an upstream pipeline (snowflake repo). Still need to coordinate whether and how to integrate the script into the build process of this repo.

@whummer whummer added the semver: patch Non-breaking changes which can be included in patch releases label Feb 19, 2024
@coveralls
Copy link

Coverage Status

coverage: 83.839% (-0.02%) from 83.858%
when pulling a3cba16 on docker-helper
into 6880b98 on master.

Copy link

LocalStack Community integration with Pro

    2 files  ± 0      2 suites  ±0   1h 26m 46s ⏱️ + 2m 15s
2 657 tests +12  2 406 ✅ +9  251 💤 +3  0 ❌ ±0 
2 659 runs  +12  2 406 ✅ +9  253 💤 +3  0 ❌ ±0 

Results for commit 0c4b4b3. ± Comparison against base commit 6880b98.

This pull request removes 1 and adds 13 tests. Note that renamed tests count towards both.
tests.aws.services.lambda_.test_lambda.TestLambdaURL ‑ test_lambda_url_echo_invoke
tests.aws.services.cloudformation.resources.test_apigateway.TestServerlessApigwLambda ‑ test_serverless_like_deployment_with_update
tests.aws.services.lambda_.test_lambda.TestLambdaURL ‑ test_lambda_update_function_url_config
tests.aws.services.lambda_.test_lambda.TestLambdaURL ‑ test_lambda_url_echo_invoke[BUFFERED]
tests.aws.services.lambda_.test_lambda.TestLambdaURL ‑ test_lambda_url_echo_invoke[None]
tests.aws.services.lambda_.test_lambda.TestLambdaURL ‑ test_lambda_url_echo_invoke[RESPONSE_STREAM]
tests.aws.services.lambda_.test_lambda.TestLambdaURL ‑ test_lambda_url_invalid_invoke_mode
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_fifo_high_throughput_ordering[sqs]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_fifo_high_throughput_ordering[sqs_json]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_sqs_fifo_same_dedup_id_different_message_groups[sqs]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_sqs_fifo_same_dedup_id_different_message_groups[sqs_json]
…

@alexrashed alexrashed added this to the Playground milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants