Handle analytics publishing errors more gracefully

[whummer]

Motivation

In a support channel, we've seen error stack trace related to SSL verification when connecting to the analytics service (can happen if the user is behind a corporate proxy/firewall).

This behavior can be reproduced by setting analytics.localstack.cloud to an invalid IP address (where the TLS certificate doesn't match our hostname), then shutting down the container:

$ DOCKER_FLAGS='--add-host analytics.localstack.cloud:1.1.1.1' DEBUG=1 localstack start
...
Ready.

[CTRL-C]
...
  File "/opt/code/localstack/.venv/lib/python3.11/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/code/localstack/.venv/lib/python3.11/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/code/localstack/.venv/lib/python3.11/site-packages/requests/adapters.py", line 517, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: MyHTTPSConnectionPool(host='analytics.localstack.cloud', port=443): Max retries exceeded with url: /v1/events (Caused by SSLError(SSLCertVerificationError(1, "[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Hostname mismatch, certificate is not valid for 'analytics.localstack.cloud'. (_ssl.c:1006)")))
LocalStack supervisor: localstack process (PID 15) returned with exit code 0

These logs should not be presented to the user, and the error also causes the shutdown hooks not to be executed properly on shutdown in stop_infra().

Changes

Add a try/except block to catch the exception, and log it with an INFO log message.

Let me know if you'd like to see this covered with a test - happy to try and wire something up, if we think it could be useful.

[github-actions]

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 22m 7s ⏱️ -40s
2 623 tests ±0  2 374 ✅ ±0  249 💤 ±0  0 ❌ ±0 
2 625 runs  ±0  2 374 ✅ ±0  251 💤 ±0  0 ❌ ±0 

Results for commit 2d81292. ± Comparison against base commit e2e054a.

♻️ This comment has been updated with latest results.

[alexrashed]

LGTM! Thanks for jumping on this! The fix is straight forward and minimal. 💯

[coveralls]

coverage: 83.84% (-0.002%) from 83.842%
when pulling 9d504f6 on analytics-errors
into e2e054a on master.

[thrau]

Thanks for identifying the culprit! Before we merge I just want to understand why we are using a AnalyticsClientPublisher directly, rather than using localstack.utils.analytics.log, which already handles errors and logging.
@dominikschubert do you remember?

[thrau]

is there a reason for not using the global analytics bus here? it already does buffering and graceful handling of errors