Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pulumi.dev.yaml content #916

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

MarcelStranak
Copy link
Contributor

The list provided in the documentation is outdated, and when you try to use pulumi up, it ends up with an error.

error: pulumi:providers:aws resource 'default_6_8_0' has a problem: could not validate provider configuration: Invalid or unknown key. Check pulumi config get aws:endpoints.

The list provided in the documentation is outdated, and when you try to use `pulumi up`, it ends up with an error.

```
error: pulumi:providers:aws resource 'default_6_8_0' has a problem: could not validate provider configuration: Invalid or unknown key. Check pulumi config get aws:endpoints.
```
Copy link

github-actions bot commented Nov 15, 2023

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-916.surge.sh 🎊

aws:skipCredentialsValidation: 'true'
aws:skipRequestingAccountId: 'true'
aws:skipCredentialsValidation: "true"
aws:skipRequestingAccountId: "true"
aws:endpoints:
Copy link
Contributor

@lakkeger lakkeger Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's a good practice to provide a drop-in project file for the users with all the available endpoints without a disclaimer or note, because the list can change by every version of the package.
Perhaps just giving a couple of examples and point them to the actual package docs would be a better idea.
Docs: https://www.pulumi.com/registry/packages/aws/api-docs/provider/#providerendpoint

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to say for me. I prefer complete docs. We do have some similar docs for Terraform, but they also look outdated.

@HarshCasper can you please share your input on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants