Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add nav buttons in footer. Make 'privacy policy' link more readable #325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snhardin
Copy link
Contributor

Fixes #69

  • Adds navigation buttons in the footer to move to the previous and next pages in the section.
  • Changes "Privacy Policy" link to be visible.

@github-actions
Copy link

github-actions bot commented Oct 28, 2022

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-325.surge.sh 🎊

@snhardin
Copy link
Contributor Author

snhardin commented Oct 28, 2022

With both previous and next links visible:

footer with both links visible

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi! thanks for the contribution. i think this is a nice idea, but it would be great if we could move the links into the page container rather than the footer. i think the links are not very visible in the footer, and i'm not sure they really belong there. maybe above the "last modified" at the bottom of the page container?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs readability enhancement: Adding Previous and Next pages Footer
3 participants