Clarify dev dependencies for host mode #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1182.surge.sh 🎊 |
joe4dev
commented
Apr 17, 2024
2 tasks
HarshCasper
approved these changes
Apr 18, 2024
alexrashed
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Thanks so much for churning over this outdated documentation! Really great to see the contribution guides being updated to simplify the onboarding of new contributors! 🚀
I only found some small things, broken links, and some leftovers. Afterwards we're good to go! 💯
Thanks again for jumping on this! 🦸🏽
joe4dev
force-pushed
the
clarify-dev-dependencies
branch
from
1737dd4
to
9b8acdb
Compare
alexrashed
approved these changes
Apr 18, 2024
|
@bentsku I re-added Node.js as a mandatory dependency given that it is required to run any test. Thanks for your input 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently missing a description of how what extra dependencies are required for running in host mode. This PR provides initial instructions and improves the dev setup guide.
As suggested by @alexrashed in a review comment here.