Algae commands for Spin Roller and Extend Intake. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made the extend intake command thing to control the pivot speed or whatever.
Made the spin roller command for the roller speed.
pigrammer3
requested changes
Jan 21, 2025
| private final AlgaeIntake algaeIntake; | ||
| private final double speed; | ||
|
|
||
| public ExtendIntake(AlgaeIntake algaeIntake, double speed) { |
There was a problem hiding this comment.
Remember, a constructor must have the exact same name as its class - ExtendIntakeCommand in this instance.
| import edu.wpi.first.wpilibj2.command.Command; | ||
| import frc.robot.subsystems.algaeIntake.AlgaeIntake; | ||
|
|
||
| public class ExtendIntakeCommand extends Command{ |
There was a problem hiding this comment.
Not critical but for visual stuff - have a space in between Command and the opening curly brace.
Suggested change
| public class ExtendIntakeCommand extends Command{ | |
| public class ExtendIntakeCommand extends Command { |
Comment on lines
+8
to
+10
| private final double speed; | ||
|
|
||
| public SpinRoller(AlgaeIntake algaeIntake, double speed) { |
There was a problem hiding this comment.
Same thing I said with the other class - the constructor has to have the exact same name as the class (SpinRollerCommand).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the commands.