Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wechat login error: make next-auth compatible for text/plain response type #6585

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

xiangnanscu
Copy link
Contributor

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

fix as discussed in #6131

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

Copy link

vercel bot commented Feb 27, 2025

@xiangnanscu is attempting to deploy a commit to the LobeChat Desktop Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ๐Ÿ› Bug Something isn't working | ็ผบ้™ท labels Feb 27, 2025
@lobehubbot
Copy link
Member

๐Ÿ‘ @xiangnanscu

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 91.61%. Comparing base (55b5416) to head (f7a36ee).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6585   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         699      699           
  Lines       65856    65856           
  Branches     4659     4659           
=======================================
  Hits        60336    60336           
  Misses       5520     5520           
Flag Coverage ฮ”
app 91.61% <รธ> (รธ)
server 97.57% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented Mar 3, 2025

ๆˆ‘็œ‹ https://github.com/nextauthjs/next-auth/blob/main/packages/core/src/providers/wechat.ts#L104-L117 ่ฟ™้‡Œๅทฒ็ปๆœ‰ไบ†ใ€‚ไธบๅ•ฅ่ฟ˜้œ€่ฆๅœจ LobeChat ้‡ŒๅŠ ไธ€้“๏ผŸ

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


I've seen https://github.com/nextauthjs/next-auth/blob/main/packages/core/src/providers/wechat.ts#L104-L117 already available here. Why do you still need to add a bun in LobeChat?

@xiangnanscu
Copy link
Contributor Author

@arvinxx ไธบไบ†ไฟฎๅคๆ— ๆณ•ไฝฟ็”จๅพฎไฟกๆ‰ซ็ ็™ปๅฝ•็š„้—ฎ้ข˜.่ง:
nextauthjs/next-auth#12661
#6131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ› Bug Something isn't working | ็ผบ้™ท size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants