Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

โœจ feat: Add changelog modal #4800

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

โœจ feat: Add changelog modal #4800

wants to merge 9 commits into from
+2,767 โˆ’183

Conversation

canisminor1990
Copy link
Member

@canisminor1990 canisminor1990 commented Nov 26, 2024 •
edited
Loading

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

image

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-database โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Dec 10, 2024 2:48pm
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Dec 10, 2024 2:48pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ๐ŸŒ  Feature Request New feature or request | ็‰นๆ€งไธŽๅปบ่ฎฎ labels Nov 26, 2024
arvinxx
arvinxx reviewed Nov 26, 2024
View reviewed changes
src/app/(main)/_layout/Desktop.tsx Outdated Show resolved Hide resolved
src/services/changelog.ts Outdated

import { Locales } from '@/locales/resources';

const BASE_URL = 'https://raw.githubusercontent.com';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

่ฟ™ไธชไผšๅฏผ่‡ดๅชๆœ‰็”จๆˆท้‚ฃ่พน็ฟปๅข™ไบ†ๆ‰่ƒฝ็œ‹ๅˆฐ changelog๏ผŒๆ„Ÿ่ง‰่ฟ™ไธช่ฏทๆฑ‚้€ป่พ‘ๅบ”่ฏฅ่ฆๅšไธ€ไปฝๅˆฐ server ๅŽป่ฏทๆฑ‚ใ€‚่ตฐ edge ็š„ trpc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ๅคดๅ›พไนŸๆœ‰่ฟ™ไธช้—ฎ้ข˜

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

้‚ฃๅคดๅ›พๆ˜ฏไธๆ˜ฏๅบ”่ฏฅ่ตฐไธ€้“ไธŠไผ ๏ผŒ่ฝฌๅˆฐr2้‡ŒๅŽป๏ผŸ

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.19565% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.11%. Comparing base (54ce087) to head (490e71e).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/server/services/changelog/index.ts 95.48% 7 Missing โš ๏ธ
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4800      +/-   ##
==========================================
+ Coverage   92.08%   92.11%   +0.02%     
==========================================
  Files         528      528              
  Lines       40116    40272     +156     
  Branches     2495     3713    +1218     
==========================================
+ Hits        36942    37096     +154     
- Misses       3174     3176       +2
Flag Coverage ฮ”
app 92.11% <96.19%> (+0.02%) โฌ†๏ธ
server 98.12% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@arvinxx arvinxx force-pushed the feat/changelog-modal branch from 37a185a to 49430c4 Compare December 1, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvinxx arvinxx Awaiting requested review from arvinxx

Assignees
No one assigned
Labels
๐ŸŒ  Feature Request New feature or request | ็‰นๆ€งไธŽๅปบ่ฎฎ size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canisminor1990 @arvinxx