Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: Fix GitHub model fetch #4645

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BrandonStudio
Copy link
Contributor

Refactor OpenAICompatibleFactory

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

  • Fix GitHub models method.
  • Refactor models parameter of OpenAICompatibleFactory.

📝 补充信息 | Additional Information

Fix #4547 (3/3).

This PR should not be merged before #4260.

Refactor OpenAICompatibleFactory
Copy link

vercel bot commented Nov 8, 2024

@BrandonStudio is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (e1f6a3a) to head (3921ada).
Report is 93 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #4645     +/-   ##
=========================================
  Coverage   92.48%   92.48%             
=========================================
  Files         511      530     +19     
  Lines       36614    36972    +358     
  Branches     3388     2323   -1065     
=========================================
+ Hits        33862    34195    +333     
- Misses       2752     2777     +25     
Flag Coverage Δ
app 92.48% <100.00%> (+<0.01%) ⬆️
server 96.17% <ø> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BrandonStudio BrandonStudio changed the title Fix GitHub model fetch ♻️ refactor: Fix GitHub model fetch Nov 24, 2024
@BrandonStudio BrandonStudio marked this pull request as ready for review November 25, 2024 01:48
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] "Get Model List" clears out Github models
2 participants