feat(DB): Add new v_abgegrenzte_interessenbindung view #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scito
reviewed
Oct 6, 2021
Adds a new database view `v_abgegrenzte_interessenbindung` which in contrast to the `interessebindung` table has the columns `von_effektiv` and `bis_effektiv` to represent the start and end date for the validity period (as opposed to `von` and `bis`). These dates are never `null` and when the end date is yet unknown (open-ended) the `bis_effektiv` will be represented by the date 9999-12-31. The value for `von_effektiv` will correspond to `von` when given and otherwise to `freigabe_datum` or `parlamentarier.im_rat_seit`, in case the `interessebindung` row was created as part of the initial research of the politician. Also note that in case a politician was elected for two non-consecutive periods of time (cf. `parlamentarier.ratsunterbruch_von` and `parlamentarier.ratsunterbruch_bis`), then the same `interessebindung` object may (depending on `von` and `bis`) end up being represented by multiple rows in this view (both with the same value for `interessebindung_id`).
knutwannheden
force-pushed
the
interessebindungen_view
branch
from
a9e9ddf
to
d6eb97c
Compare
knutwannheden
commented
Oct 11, 2021
| join parlamentarier_amtszeit pa on pa.id = i.parlamentarier_id | ||
| join organisation o on i.organisation_id = o.id | ||
| and von_effektiv <= coalesce(bis, date '9999-12-31') | ||
| and coalesce(bis_effektiv, date '9999-12-31') > coalesce(von, i.freigabe_datum) |
There was a problem hiding this comment.
Wie du siehst habe ich hier und da das Datum 9999-12-31 verwendet. Dies erleichtert es Abfragen gegen diese View zu schreiben, da NULL nicht hantiert werden muss. Falls das ein "Stilbruch" ist, können wir das aber auch gerne wieder entfernen oder mit einem anderen Datum ersetzen. (Irgendwo habe ich 2038-01-01 gesehen, das ist aber schon "relativ bald".)
Du hast vermutlich auch gesehen, dass ich Date Literals so schreibe: date '9999-12-31'. Dies sollte portabel sein, aber wenn es dir lieber ist, schreibe ich es auf STR_TO_DATE('31.12.9999','%d.%m.%Y') um.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new database view
v_abgegrenzte_interessenbindungwhich in contrast to theinteressebindungtable has the columnsvon_effektivandbis_effektivto represent the start and end date for the validity period (as opposed tovonandbis). These dates are nevernulland when the end date is yet unknown (open-ended) thebis_effektivwill be represented by the date 9999-12-31.The value for
von_effektivwill correspond tovonwhen given and otherwise tofreigabe_datumorparlamentarier.im_rat_seit, in case theinteressebindungrow was created as part of the initial research of the politician.Also note that in case a politician was elected for two non-consecutive periods of time (cf.
parlamentarier.ratsunterbruch_vonandparlamentarier.ratsunterbruch_bis), then the sameinteressebindungobject may (depending onvonandbis) end up being represented by multiple rows in this view (both with the same value forinteressebindung_id).Related: #18