update build-ios.yml + build-macos.yml

loay-ashraf · Aug 24, 2023 · 3c228a7 · 3c228a7
1 parent ee74435
commit 3c228a7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 27 deletions.
diff --git a/.github/workflows/build-ios.yml b/.github/workflows/build-ios.yml
@@ -12,10 +12,6 @@ jobs:
  framework-ios-simulator:
  name: Build Framework For iOS Simulator
  runs-on: macos-13
-# strategy:
-# matrix:
-# destination: ['generic/platform=iOS Simulator',
-# 'generic/platform=iOS']
 
  steps:
  - name: Checkout
@@ -35,10 +31,6 @@ jobs:
  framework-ios:
  name: Build Framework For iOS Device
  runs-on: macos-13
-# strategy:
-# matrix:
-# destination: ['generic/platform=iOS Simulator',
-# 'generic/platform=iOS']
 
  steps:
  - name: Checkout
@@ -58,10 +50,6 @@ jobs:
  example-ios-simulator:
  name: Build Example For iOS Simulator
  runs-on: macos-13
-# strategy:
-# matrix:
-# destination: ['generic/platform=iOS Simulator',
-# 'generic/platform=iOS']
  needs: framework-ios-simulator
 
  steps:
@@ -82,10 +70,6 @@ jobs:
  example-ios:
  name: Build Example For iOS Device
  runs-on: macos-13
-# strategy:
-# matrix:
-# destination: ['generic/platform=iOS Simulator',
-# 'generic/platform=iOS']
  needs: framework-ios
 
  steps:

diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml
@@ -9,12 +9,9 @@ on:
  - '**'
 
 jobs:
- framework:
+ framework-macos:
  name: Build Framework Scheme
  runs-on: macos-13
- strategy:
- matrix:
- destination: ['generic/platform=macOS']
 
  steps:
  - name: Checkout
@@ -27,16 +24,14 @@ jobs:
  env:
  workspace: RxNetworkKit.xcworkspace
  scheme: RxNetworkKit
- destination: ${{ matrix.destination }}
+ destination: generic/platform=macOS
  run: |
  xcodebuild clean build -workspace "${workspace}" -scheme "${scheme}" -destination "${destination}" | xcpretty && exit ${PIPESTATUS[0]}
- example:
+ 
+ example-macos:
  name: Build Example Scheme
  runs-on: macos-13
- strategy:
- matrix:
- destination: ['generic/platform=macOS']
- needs: framework
+ needs: framework-macos
 
  steps:
  - name: Checkout
@@ -49,7 +44,7 @@ jobs:
  env:
  workspace: RxNetworkKit.xcworkspace
  scheme: macOS Example
- destination: ${{ matrix.destination }}
+ destination: generic/platform=macOS
  run: |
  xcodebuild clean build -workspace "${workspace}" -scheme "${scheme}" -destination "${destination}" CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO | xcpretty && exit ${PIPESTATUS[0]}