Common action states and variants #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CLA signed
yagil
approved these changes
Mar 26, 2025
|
I moved the new localization keys to the rool level of the shared.json file, rather than all nested with The only hesitation I had with this was that the rest of the shared root is already a bit cluttered with some items which seem like they should go in other localization files - some non-global content mixed in Think it's ok to put the new keys at root level too? just want to make sure we all like the structure, since hopefully these will be used a lot @yagil |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding to the shared localization file a handful of common action states which are duplicated frequently in existing localization definitions. The goal will be to use these moving forward when needing a generic action state localization, such as "Cancel" or "Done"