Add Python image upload docs #48
Merged
+104
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CLA signed
|
Keeping as draft until version 1.1.0 of the Python SDK has been published to PyPI |
Comment on lines
+64
to
+67
| If you only have the raw data of the image, you can supply the raw data directly as a bytes | ||
| object without having to write it to disk first. Due to this feature, binary filesystem | ||
| paths are *not* supported (as they will be handled as malformed image data rather than as | ||
| filesystem paths). |
There was a problem hiding this comment.
This confuses a bit as a Python noob. Maybe provide an example with raw binary input and an example and then an example with IO objects? Though maybe it is unnecessary?
There was a problem hiding this comment.
Yeah, this bit could definitely be improved to something more like the JS base64 example, but I'd like to hold off on improving it until lmstudio-ai/lmstudio-python#46 has been implemented
That way we can do a more useful example like using pillow to load an image in a format LM Studio doesn't support, and send it to the server in a supported format.
yagil
approved these changes
Mar 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.