Regression: Add DbiFlags#MDB_UNSIGNEDKEY to allow to compare byte array, ByteBuffer and DirectBuffer keys as unsigned like in versions prior to 0.9.0 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdprete
force-pushed
the
fix/unsigned-compare
branch
3 times, most recently
from
da3d6ee
to
21cf932
Compare
This was referenced Mar 6, 2024
cdprete
force-pushed
the
fix/unsigned-compare
branch
2 times, most recently
from
6e56d33
to
e28a711
Compare
|
@benalexau A test for this was done in #230 (comment) |
cdprete
force-pushed
the
fix/unsigned-compare
branch
2 times, most recently
from
9c91ca7
to
61a2ac4
Compare
…ay, ByteBuffer and DirectBuffer keys as unsigned like in versions prior to 0.9.0
cdprete
force-pushed
the
fix/unsigned-compare
branch
from
61a2ac4
to
1fc58e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228 and #230.
I was not able to run the tests locally on Windows (I'm getting a
NoClassDefFoundErrorkind of everywhere), so I hope I didn't break any.