Skip to content

TableGen: Fixed the string table definitions visibility. #148946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025

Conversation

vzakhari
Copy link
Contributor

This fixes the buildbots issues reported in #148839.

This fixes the buildbots issues reported in llvm#148839.
@llvmbot
Copy link
Member

llvmbot commented Jul 15, 2025

@llvm/pr-subscribers-tablegen

Author: Slava Zakharin (vzakhari)

Changes

This fixes the buildbots issues reported in #148839.


Full diff: https://github.com/llvm/llvm-project/pull/148946.diff

1 Files Affected:

  • (modified) llvm/lib/TableGen/StringToOffsetTable.cpp (+3-2)
diff --git a/llvm/lib/TableGen/StringToOffsetTable.cpp b/llvm/lib/TableGen/StringToOffsetTable.cpp
index d6d2c2590389a..41f82caa12f82 100644
--- a/llvm/lib/TableGen/StringToOffsetTable.cpp
+++ b/llvm/lib/TableGen/StringToOffsetTable.cpp
@@ -83,10 +83,11 @@ void StringToOffsetTable::EmitStringTableDef(raw_ostream &OS,
 #pragma GCC diagnostic pop
 #endif
 
-{1}constexpr llvm::StringTable
+{1} llvm::StringTable
 {2}{0} = {0}Storage;
 )",
-                Name, ClassPrefix.empty() ? "static " : "", ClassPrefix);
+                Name, ClassPrefix.empty() ? "static constexpr" : "const",
+                ClassPrefix);
 }
 
 void StringToOffsetTable::EmitString(raw_ostream &O) const {

@jurahul
Copy link
Contributor

jurahul commented Jul 15, 2025

Can you also update the lit test?

@jurahul
Copy link
Contributor

jurahul commented Jul 15, 2025

Thanks for fixing the failure.

@vzakhari vzakhari merged commit e685e4a into llvm:main Jul 15, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants