-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Caylx] canonicalization results in invalid IR: ifOp w/empty else #7050
Comments
There are other similar occurrences, such as:
Probably the verifier is meant to ensure --after all canonicalizers run-- that no useless things are left. Hmm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Verifier checks that else region is non-empty if present.
Current patterns can fail this verification, for example when the else region contains some control op that removes itself (
emptyControl<OpTy>
) the containing block is now newly empty and fails verification.Caught by
-DMLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS=ON.
.cc #7047.
This can be observed with the following example from
test/Dialect/Calyx/canonicalization.mlir
:The text was updated successfully, but these errors were encountered: