Skip to content

Commit 0102a61

Browse files
committed
[Python] Remove dependency on MLIRPythonSources.Dialects.builtin.
This specific dependency no longer works after an upstream change: llvm/llvm-project#97167. Furthermore, we never actually wanted this dependency, since we don't actually do anything with the builtin dialect ops. We only used this to convince the MLIR bindings to do the automatic downcasting for builtin dialect types and attributes, which required the builtin dialect to be registered (even though it always is) until this change went in: llvm/llvm-project#72338. Now that these changes are behind us, we can remove our workaround and avoid the issues that ensue by depending on a target no one usually depends on.
1 parent 6eff7ed commit 0102a61

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lib/Bindings/Python/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,6 @@ add_mlir_python_modules(CIRCTPythonModules
192192
INSTALL_PREFIX "python_packages/circt_core/circt"
193193
DECLARED_SOURCES
194194
MLIRPythonSources.Core
195-
MLIRPythonSources.Dialects.builtin
196195
CIRCTBindingsPythonExtension
197196
CIRCTBindingsPythonSources
198197
COMMON_CAPI_LINK_LIBS

0 commit comments

Comments
 (0)