Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug impls should use DebugStruct #153

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

ExpHP
Copy link
Collaborator

@ExpHP ExpHP commented Mar 21, 2019

Just best practices; Debug impls should use the helpers on fmt::Formatter when possible in order to properly support {:#?}.

Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I didn't know about debug_struct

@lloydmeta
Copy link
Owner

I think after the conflicts in this one are fixed + merged, with #148 and #152, we have (more than) enough for a new minor-version-bumped release.

@ExpHP
Copy link
Collaborator Author

ExpHP commented Mar 22, 2019

The next release has to be a major version bump because of the change to features in the no_std PR. For instance, somebody could be using Validated with default_features = false.

For that reason, I also want to close at least #138 which seems easy enough.

@lloydmeta
Copy link
Owner

The next release has to be a major version bump because of the change to features in the no_std PR. For instance, somebody could be using Validated with default_features = false.

For that reason, I also want to close at least #138 which seems easy enough.

🤦‍♂️ yes of course you're right; it needs to be a major bump.

@lloydmeta lloydmeta merged commit 62248c2 into lloydmeta:master Mar 23, 2019
@lloydmeta
Copy link
Owner

lloydmeta commented Mar 23, 2019

Hmm, actually no, I think since we are in x.y.z where x < 1 world, we are ok with just bumping the minor, even with a breaking change, and leaving a note

Staying with a minor version bump seems more preferable to me than force-introducing a 1.x.x which has major implications.

@ExpHP
Copy link
Collaborator Author

ExpHP commented Mar 23, 2019

To be clear, 0.3.0 is what I meant by a major version bump. (I meant a bump of the first nonzero part of the version number, to indicate semver incompatibility)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants