Skip to content

Add the --use-z-loss option to v4 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v4
Choose a base branch
from
Open

Add the --use-z-loss option to v4 #19

wants to merge 2 commits into from

Conversation

hkiyomaru
Copy link
Member

What

Add the --use-z-loss option to v4, ensuring backward compatibility with existing behavior.

@hkiyomaru hkiyomaru changed the base branch from nii-geniac to v4 April 17, 2025 06:53
@hkiyomaru hkiyomaru marked this pull request as ready for review April 17, 2025 10:07
@hkiyomaru hkiyomaru requested review from odashi and Copilot April 17, 2025 10:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Copy link
Member

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use_z_loss ではなく z_loss_strength をコマンドライン引数とした方が、定数を決めるための余計なコードが省けてすっきりすると思います。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants