Skip to content

Limits if check for manual unlocking #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ScuffedNewt
Copy link
Contributor

Would like someone to double check my logic here but:

line 53 in LimitManager.php was

if (!$is_unlock && $limits->first()->is_unlocked && !$limits->first()->is_auto_unlocked) {

this is wrong because $limits->first()->is_unlocked is already checked prior, & conflicts with the is_auto_unlocked

Updated to

if (!$is_unlock && !$limits->first()->is_auto_unlocked) {

@itinerare itinerare added bug Something isn't working needs review Pull requests that are pending community review labels Jun 14, 2025
@SpeedyD
Copy link
Contributor

SpeedyD commented Jun 16, 2025

this is wrong because $limits->first()->is_unlocked is already checked prior, & conflicts with the is_auto_unlocked

Long story short, it IS checked prior AND if it conflicts, it needs to be fixed. I think your logic is solid. 👍


..Anyway.. I would like to review this proper at some point, but I do not have the brain power right now =_=;..

What I can't figure out is where CheckLimits is called, I need to know what SETS $is_unlock to true, since it's false by default..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs review Pull requests that are pending community review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants