Feat: fix minor bugs with trades & add tradelistings, trade proposals #1199
Conversation
…rekeeper into trade-listings
…d if one side didn't contain anything (was represented only by entered text).
…e item under seeking - Add validation to require at least one thing on seeking/offered each (includes 'other' fields for each) - Clean up code so only supplied information/fields are json encoded - Change pagination of listings to 10 per page due to their size
ScuffedNewt
force-pushed
the
feature/trades
branch
from
15c8c53 to
e9c13ed
Compare
you can already reject proposals! |
Nah, I mean.. decline ahead of time, like a "no thanks" before getting any. |
…feature/trades # Conflicts: # resources/views/news/_news.blade.php # resources/views/pages/credits.blade.php
sorry I don't get what you mean |
Basically, what I mean is like a user setting that can ahead of time be set that the user does not want to receive trade proposals. But.. that may be out of scope for this particular PR, and may actually be a good idea for trades in general, not just proposals. (Which is why I ended it on that we should probably look into it, not actually as note for this PR.. Maybe I'll make it an issue instead.) |
good idea, definitely for me if the opt out of proposals they would be unable to create listings |
There was a problem hiding this comment.
Right- with all that said, and having opened issue #1214... there's only one thing left to do.
And that was reviewing the code. I now understand that odd question mark is in fact a feature of PHP 8.. A Nullsafe Operator. Something I will look more into in the future. But for now.. You've addressed all my issues, and as such, I approve this PR.
|
Right, if that's settled I'll take a look at this when I next have the wherewithal. |
…feature/trades # Conflicts: # resources/views/home/trades/create_trade.blade.php # resources/views/home/trades/edit_trade.blade.php # resources/views/pages/credits.blade.php # resources/views/widgets/_inventory_select.blade.php
…feature/trades
…ore being accepted
Adds trade listings to dev, also adds the ability to propose trades to users
proposals use the existing trade system, the only difference being both users can edit both sides of the trades (however it must be accepted by both users to progress like normal trades)
Please pull this locally and test