Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove liveportrait #393

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Remove liveportrait #393

merged 1 commit into from
Jan 10, 2025

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jan 8, 2025

No description provided.

@leszko leszko requested review from victorges and thomshutt January 8, 2025 08:32
@thomshutt
Copy link

LGTM, did we already remove it from the showcase?

@leszko
Copy link
Contributor Author

leszko commented Jan 8, 2025

LGTM, did we already remove it from the showcase?

It was never in the showcase app. The "Liveportrait" you see in the showcase app is "ComfyUI" with Liveportrait. This will stay the same.

What I'm removing here is the "custom" Liveportrait created by Victor (similar to what we have for Stream Diffusion). However, we were never able to productionize it.

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leszko leszko merged commit cb9f788 into main Jan 10, 2025
12 checks passed
@leszko leszko deleted the rafal/remove-liveportrait-2 branch January 10, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants