Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comfui_stablediffusion, add checkpoints and lora #364

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −1
Open

update comfui_stablediffusion, add checkpoints and lora #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f86d937
update comfui_stablediffusion, add checkpoints and lora
pschroedl Dec 13, 2024
5f1159e
Merge branch 'main' into update_comfyui_streamdiffusion
leszko Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions runner/dl_checkpoints.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ function download_live_models() {
huggingface-cli download yuvraj108c/Depth-Anything-Onnx --include depth_anything_vitl14.onnx --local-dir models/ComfyUI--models/Depth-Anything-Onnx
download_sam2_checkpoints
download_stable_diffusion_checkpoints
download_stable_diffusion_loras
}

function download_sam2_checkpoints() {
Expand All @@ -106,6 +107,17 @@ function download_sam2_checkpoints() {
function download_stable_diffusion_checkpoints() {
huggingface-cli download KBlueLeaf/kohaku-v2.1 --local-dir models/ComfyUI--models/checkpoints --include "*.safetensors"
huggingface-cli download stabilityai/sd-turbo --local-dir models/ComfyUI--models/checkpoints --include "*.safetensors"

# ComfyUI_StreamDIffusion is loading single file safetensors from /models/checkpoints
wget -P models/checkpoints/ https://huggingface.co/KBlueLeaf/kohaku-v2.1/resolve/main/kohaku-v2.1.safetensors
wget -P models/checkpoints/ https://huggingface.co/stabilityai/sd-turbo/resolve/main/sd_turbo.safetensors
# chenxxiao/3dCartoonVision_v10
wget -P models/checkpoints https://huggingface.co/chenxxiao/3dCartoonVision_v10/resolve/main/3dCartoonVision_v10.safetensors?download=true --content-disposition
Comment on lines 108 to +115
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
huggingface-cli download KBlueLeaf/kohaku-v2.1 --local-dir models/ComfyUI--models/checkpoints --include "*.safetensors"
huggingface-cli download stabilityai/sd-turbo --local-dir models/ComfyUI--models/checkpoints --include "*.safetensors"
# ComfyUI_StreamDIffusion is loading single file safetensors from /models/checkpoints
wget -P models/checkpoints/ https://huggingface.co/KBlueLeaf/kohaku-v2.1/resolve/main/kohaku-v2.1.safetensors
wget -P models/checkpoints/ https://huggingface.co/stabilityai/sd-turbo/resolve/main/sd_turbo.safetensors
# chenxxiao/3dCartoonVision_v10
wget -P models/checkpoints https://huggingface.co/chenxxiao/3dCartoonVision_v10/resolve/main/3dCartoonVision_v10.safetensors?download=true --content-disposition
huggingface-cli download KBlueLeaf/kohaku-v2.1 --local-dir models/checkpoints --include "*.safetensors"
huggingface-cli download stabilityai/sd-turbo --local-dir models/checkpoints --include "*.safetensors"
# chenxxiao/3dCartoonVision_v10
huggingface-cli download chenxxiao/3dCartoonVision_v10 --local-dir models/checkpoints --include "*.safetensors"
  1. For the sake of consistency, can we change everything to get downloaded with huggingface-cli? This what I suggested worked for me
  2. Do I understand correctly that the streamdiffusion node takes models from /models/checkpoints and not from the comfyui workspace directory /comfui/models?

}

function download_stable_diffusion_loras() {
# ral-dissolve-sd15 LoRA
wget -P models/loras https://civitai.com/api/download/models/314246?type=Model&format=SafeTensor --content-disposition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wget -P models/loras https://civitai.com/api/download/models/314246?type=Model&format=SafeTensor --content-disposition
wget -P models/loras https://civitai.com/api/download/models/314246?type=Model\&format=SafeTensor --content-disposition

This does not work for me, it requires some civitai authentication. I get the following error:

Username/Password Authentication Failed.

}

function build_tensorrt_models() {
Expand Down
2 changes: 1 addition & 1 deletion runner/docker/Dockerfile.live-base-comfyui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ RUN cd /comfyui/custom_nodes && \
RUN cd /comfyui/custom_nodes && \
git clone https://github.com/pschroedl/ComfyUI-StreamDiffusion.git && \
cd ComfyUI-StreamDiffusion && \
git checkout 032cf631385454ea99772c86377c0437c34ab733 && \
git checkout 32f88480736e30d6c1d97b9adfe483dd265769b3 && \
pip install -r requirements.txt

# Upgrade TensorRT to 10.6.0
Expand Down
Loading