Skip to content

Conversation

pschroedl
Copy link
Collaborator

comfystream setup_models.py should ultimately handle these missing nested directories, but this should unbreak staging

@pschroedl pschroedl requested a review from hjpotter92 March 7, 2025 06:25
@pschroedl
Copy link
Collaborator Author

I was just able to verify again that setup_models creates the text_encoders/CLIPText folders even when running from the docker container as happens in dl_checkpoints and deploy_models, so this probably isn't necessary ( or the issue behind this model not being found )

@eliteprox
Copy link
Collaborator

I was just able to verify again that setup_models creates the text_encoders/CLIPText folders even when running from the docker container as happens in dl_checkpoints and deploy_models, so this probably isn't necessary ( or the issue behind this model not being found )

Correct, the script creates the directories so no need to create missing ones

https://github.com/livepeer/comfystream/blob/a4c564d4e3eea7e7e5fbe801701c1f8b427ef6bc/src/comfystream/scripts/setup_models.py#L85-L94

https://github.com/livepeer/comfystream/blob/a4c564d4e3eea7e7e5fbe801701c1f8b427ef6bc/src/comfystream/scripts/setup_models.py#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants