feature idea: detect git short version hash during build and embed into binary #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…into add-buildinfo-package
|
Hey @syke99 thanks for working on this! I'm a bit confused by the PR though. It's not really connected to Bud in anyway. You'd need to add the I'm also thinking we can simplify this buildinfo package quite a bit, pretty sure something like: bud/internal/versions/versions.go Line 4 in d243eed |
|
Hey @matthewmueller, I'm so sorry. Yes, this was supposed to just be a draft PR for now. I was expecting to continue being able to work on it, but I've had some personal stuff come up that has been taking precedence, so I've had to step away. And you're right, that does seem like it would suffice for what I had added. Again, my apologies!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the first proposed solution to this issue. The second proposed solution is not implemented in this PR, but can be added with further information provided.